In rzg2l_pinconf_set and rzg2l_get_pin_muxing if the call to
rzg2l_selector_decode fails then the variable pin may not have been
assigned to. Remove the use of pin from the error message.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodb...@linaro.org>
---
 drivers/pinctrl/renesas/rzg2l-pfc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/renesas/rzg2l-pfc.c 
b/drivers/pinctrl/renesas/rzg2l-pfc.c
index 3c751e9473a..3bdba5e365c 100644
--- a/drivers/pinctrl/renesas/rzg2l-pfc.c
+++ b/drivers/pinctrl/renesas/rzg2l-pfc.c
@@ -353,7 +353,7 @@ static int rzg2l_pinconf_set(struct udevice *dev, unsigned 
int pin_selector,
                /* The pin selector refers to a multiplexed pin */
                int port = rzg2l_selector_decode(data, pin_selector, &pin);
                if (port < 0) {
-                       dev_err(dev, "Invalid pin selector %u:%u\n", port, pin);
+                       dev_err(dev, "Invalid pin selector %u\n", port);
                        return port;
                }
 
@@ -550,7 +550,7 @@ static int rzg2l_get_pin_muxing(struct udevice *dev, 
unsigned int selector,
 
        port = rzg2l_selector_decode(data, selector, &pin);
        if (port < 0) {
-               dev_err(dev, "Invalid pin selector %u:%u\n", port, pin);
+               dev_err(dev, "Invalid pin selector %u\n", port);
                return port;
        }
 

---
base-commit: 3526f990b77fca1c933f1d8b24eb9385010a05bf
change-id: 20250807-pinctrl_renesas-b48818ef01b3

Best regards,
-- 
Andrew Goodbody <andrew.goodb...@linaro.org>

Reply via email to