> David, I prefer to have two patch for this. > One is the CMD_MII support > The second is the extend UEC to 4. No problem. Will split the patch. Merging is on you though :) Regarding the MII support: This will include also a fix in the TSEC driver to enable it to address all MII addresses on the bus, regardless of the port (as someone asked here).
> I don't like so much CFG_ option for the driver, which cause too many > CFG_UEC[x]_NUM_TX_RX_THR in config.h. for every board. > > and I think the threads number is not belonged to board specific things. > The u-boot don't need to consider the UEC performance. > > The default 4 threads should work for you. > If it doesn't work for you, I suggest you keep the changes only for your > project. > > I don't know if you can agree it. > > So, please repost the UEC_ETH4 support patch. Regarding the thread number: As each UEC requires 8+ threads (4 for tx, 4 for rx), extending the number of UECs to 4 will exceed the number of QE threads. Now, 4 threads per TX/RX is only required for the GBE UEC. FE only requires one thread. So I'll change the driver in a way that it will use 4+4 threads in case of GBE, and 1+1 in case of FE. I already tested it here - and it worked fine. This way we won't need these CFG options per UEC any more. Is this ok? David. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
