On Thu, Feb 14, 2008 at 01:39:14AM +0100, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > > > > >> +#if 1 /* @ 60 Hz */ > > >> + mode->crtc_h_total_disp = 0x009f00d2; > > >> + mode->crtc_h_sync_strt_wid = 0x000e0528; > > >> + mode->crtc_v_total_disp = 0x03ff0429; > > >> + mode->crtc_v_sync_strt_wid = 0x00030400; > > >> + mode->crtc_pitch = 0x00a000a0; > > >> + mode->ppll_div_3 = 0x00010060; > > >> +#else /* @ 75 Hz */ > > >> + mode->crtc_h_total_disp = 0x009f00d2; > > >> + mode->crtc_h_sync_strt_wid = 0x00120508; > > >> + mode->crtc_v_total_disp = 0x03ff0429; > > >> + mode->crtc_v_sync_strt_wid = 0x00030400; > > >> + mode->crtc_pitch = 0x00a000a0; > > >> + mode->ppll_div_3 = 0x00010078; > > >> +#endif > > > > > > Mmm... better adding a configuration define here or just remove the > > > unused code. > > > > Ok, I'm going to drop the unused code then. > > No, please keep it as reference in case anybody needs this later.
Uh? =:-o Why did you change your mind? ;) | Delivery-date: Sun, 01 Apr 2007 15:18:41 +0200 | From: Wolfgang Denk <[EMAIL PROTECTED]> | To: Rodolfo Giometti <[EMAIL PROTECTED]> | cc: Markus Klotzb?cher <[EMAIL PROTECTED]> | Subject: Re: [PATCH] ISP116x HCD (Host Controller Driver) | | [snip] | | Please remove code in "#if 0 ... #endif" blocks. | | [snip] | | Best regards, | | Wolfgang Denk However I suggested also to add a configuration define, something like: #if defined(CFG_ATI_RADEON_60HZ) ... #elif defined(CFG_ATI_RADEON_75HZ) ... #else #error "..." #endif This allow keeping the code in a better style... or we can rewrite it as follow: /* @ 60 Hz */ mode->crtc_h_total_disp = 0x009f00d2; mode->crtc_h_sync_strt_wid = 0x000e0528; mode->crtc_v_total_disp = 0x03ff0429; mode->crtc_v_sync_strt_wid = 0x00030400; mode->crtc_pitch = 0x00a000a0; mode->ppll_div_3 = 0x00010060; /* @ 75 Hz * * Still untested. Just use it as reference for future improvemets. * * mode->crtc_h_total_disp = 0x009f00d2; * mode->crtc_h_sync_strt_wid = 0x00120508; * mode->crtc_v_total_disp = 0x03ff0429; * mode->crtc_v_sync_strt_wid = 0x00030400; * mode->crtc_pitch = 0x00a000a0; * mode->ppll_div_3 = 0x00010078; */ Ciao, Rodolfo -- GNU/Linux Solutions e-mail: [EMAIL PROTECTED] Linux Device Driver [EMAIL PROTECTED] Embedded Systems [EMAIL PROTECTED] UNIX programming phone: +39 349 2432127 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
