Dear Kim,
in message <[EMAIL PROTECTED]> you wrote:
>
> > I don't think it's exactly intuitive to have a board named
> > "mpc832xemds" and the related files use "mpc832x_mds".
> >
> > That looks awfully broken to me.
>
> afaik, you can supposedly buy an mds board with an mpc8321,
> mpc8321e, mpc8323, or an mpc8323e (the trailing 'e' denotes whether the
> crypto engine has its fuse intact). It's just the mpc8323e that is
> (probably by far) the most common.
Yes, I know. By "board name" I mean the name of the configuration in
U-Boot, and the related file names i. e.
Makefile: MPC8323ERDB_config
MPC832XEMDS_config
MPC832XEMDS_HOST_33_config
MPC832XEMDS_HOST_66_config
MPC832XEMDS_SLAVE_config
MPC832XEMDS_ATM_config
doc/README.mpc8323erdb
doc/README.mpc832xemds
include/configs/MPC8323ERDB.h
include/configs/MPC832XEMDS.h
board/freescale/mpc8323erdb/Makefile
board/freescale/mpc8323erdb/config.mk
board/freescale/mpc8323erdb/mpc8323erdb.c
board/freescale/mpc832xemds/Makefile
board/freescale/mpc832xemds/config.mk
board/freescale/mpc832xemds/mpc832xemds.c
board/freescale/mpc832xemds/pci.c
and:
CONFIG_MPC832XEMDS
compare Linux:
arch/powerpc/configs/mpc832x_mds_defconfig
arch/powerpc/configs/mpc832x_rdb_defconfig
arch/powerpc/boot/dts/mpc832x_mds.dts
arch/powerpc/boot/dts/mpc832x_rdb.dts
arch/powerpc/platforms/83xx/mpc832x_mds.c
arch/powerpc/platforms/83xx/mpc832x_rdb.c
and:
CONFIG_MPC832x_MDS
> linux board support files are consistent /within/ linux, and u-boot
No, not even this.
arch/powerpc/boot/dts/mpc832x_mds.dts says:
* MPC8323E EMDS Device Tree Source
model = "MPC8323EMDS";
compatible = "MPC8323EMDS", "MPC832xMDS", "MPC83xxMDS";
There is no name with an underscore there.
> board support files are intra-u-boot consistent; it's just this
> particular file (the device tree) needs to be inter-linux and u-boot
> consistent (for interoperability purposes). Since linux does currently
As you can see above, there are more places where the same name
could or rather should be shared between U-Boot and Linux:
- for the board specific #define's
- for the board configuration ("MAKEALL foo" resp. "make foo_config"
in U-Boot and "make foo_defconfig" in Linux)
- for the file names in the source trees
Depending on your lab setup, you probably also share between U-Boot
and Linux
- the name of the /tftpboot directory
- the name of the BDI2000 config file
- the port name on the terminal server for serial console access
- the port name remote power switch unit
> host the device tree files, we should probably follow their naming
> scheme, unless you want to discuss hosting device tree files in
> u-boot ;).
>
> fyi, the board file was changed in the linux git tree commit
> be156bed9ebfe365c6d95f715eae3529cf694fcb
But OK - that's your stuff. I will not block your commit now, but I
really think this shouldbe cleaned up - in your own interest, and in
the interest of your users.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
If I don't document something, it's usually either for a good reason,
or a bad reason. In this case it's a good reason. :-)
- Larry Wall in <[EMAIL PROTECTED]>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
