Dear Dave,
in message <[EMAIL PROTECTED]> you wrote:
>
> The patch set include two parts:
> 1. SATA framework support
> 2. The Freescale SATA controller support
...
> Dave Liu (8):
> ATA: Add the support for SATA framework
Why add new support? We already have some...
> board/freescale/mpc837xemds/mpc837xemds.c | 3 +
> common/Makefile | 1 +
> common/cmd_sata2.c | 206 +++++++
Can you please explain why we need a new file common/cmd_sata2.c
which duplicates a lot of functions of the already existing
common/cmd_sata.c ?
I think this needs to be cleaned up. I will not accept multiple
similar but conflicting implementations of the very same functions.
I hereby NAK the whole patch series.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Man is the best computer we can put aboard a spacecraft ... and the
only one that can be mass produced with unskilled labor.
-- Wernher von Braun
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
