Dear Dave, in message <[EMAIL PROTECTED]> you wrote: > > -----Original Message----- > From: Wolfgang Denk [mailto:[EMAIL PROTECTED] > Sent: Wed 3/26/2008 7:58 AM > To: Liu Dave > Cc: u-boot-external; Phillips Kim > Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch > set > > Dear Dave, > > in message <[EMAIL PROTECTED]> you wrote: > > > > The patch set include two parts: > > 1. SATA framework support > > 2. The Freescale SATA controller support > ... > > Dave Liu (8): > > ATA: Add the support for SATA framework > > Why add new support? We already have some... > > [dave] really, I didn't find any SATA framework support in u-boot. > if you are saying the cmd_sata.c. I don't agree it.
Your message is extremely difficult to read. Can you please use proper quoting? Please read http://www.netmeister.org/news/learn2quote.html if you need help... > > board/freescale/mpc837xemds/mpc837xemds.c | 3 + > > common/Makefile | 1 + > > common/cmd_sata2.c | 206 +++++++ > > Can you please explain why we need a new file common/cmd_sata2.c > which duplicates a lot of functions of the already existing > common/cmd_sata.c ? > > [dave]the common/cmd_sata.c is more likely controller specificed driver, not > sata framework. the cmd_sata2.c is more generic. can connect to different SATA > controller driver. Maybe. But still both the existing common/cmd_sata.c and your new cmd_sata2.c implement the very same functions (like do_sata()) with more or less the same sub-commands etc. > I think this needs to be cleaned up. I will not accept multiple > similar but conflicting implementations of the very same functions. > > [dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to > drivers/block. Sorry, but this will not work. I will not add such duplicated code. Please add command level stuff to the (existing) common/cmd_sata.c file and do not add any new cmd_sata2.c which duplicates it. If necessary, clean up the code while you're there. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Whom the gods would destroy, they first teach BASIC. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
