Hi Eugene, On Monday 07 April 2008, Eugene O'Brien wrote: > I had a look at all PPC440 processor manuals from AMCC and see that my > patch applies to all of them. In other words the #else portion is never > used. Therefore I am submitting a patch that cleans up this code quite > nicely.
Great, thanks. > Another observation that I made is that the PPC440EPx and PPC440GPx > require more than 32 bits to control the power management functions. > Therefore I defined a second set of registers cpc1_er, cpc1_fr, cpc1_sr > for these processors. These can be used as placeholders for future > development. I would prefer to add those when really needed. Let's try to include only defines that are used. This way the headers don't get "polluted" even more. > Let me know if this sounds good to you. Could you please resend you patch without those new registers? And please send it inline and add a proper Signed-off-by line as described here: http://www.denx.de/wiki/UBoot/Patches I suggest to use git-send-email for sending patches. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
