In message <[EMAIL PROTECTED]> you wrote:
>
> Add support for the AT91RM9200EK Board.
I guess you are aware that the merge window is not open, i. e. you are
submitting this only for discussion here...
> diff -urN u-boot.cmp/board/atmel/at91rm9200ek/at91rm9200ek.c
> u-boot/board/atmel/at91rm9200ek/at91rm9200ek.c
> --- u-boot.cmp/board/atmel/at91rm9200ek/at91rm9200ek.c 1970-01-01
> 01:00:00.000000000 +0100
> +++ u-boot/board/atmel/at91rm9200ek/at91rm9200ek.c 2008-04-12
> 21:28:59.000000000 +0200
> @@ -0,0 +1,142 @@
> +/*
> + * (C) Copyright 2002
> + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> + * Marius Groeger <[EMAIL PROTECTED]>
A new file, and these are the only copyright holders? Really? Ditto
for the other files.
There are coding style issues: trailing white space,
> diff -urN u-boot.cmp/board/atmel/at91rm9200ek/flash.c
> u-boot/board/atmel/at91rm9200ek/flash.c
> --- u-boot.cmp/board/atmel/at91rm9200ek/flash.c 1970-01-01
> 01:00:00.000000000 +0100
> +++ u-boot/board/atmel/at91rm9200ek/flash.c 2008-04-12 21:15:08.000000000
> +0200
> @@ -0,0 +1,509 @@
> +/*
> + * (C) Copyright 2002
> + * Lineo, Inc. <www.lineo.com>
> + * Bernhard Kuhn <[EMAIL PROTECTED]>
I think this is CFI conformant flash, isn't it? So please use the CFI
driver instead.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Microsoft Multitasking:
several applications can crash at the same time.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
