On Friday 18 April 2008, Larry Johnson wrote: > I was just about to post on I problem I belatedly found with PCI on our > Korat PPC400EPx board. (I believe the same problem exists on the > Sequoia board, but have not proved it.) What appears to have broken it > was the following patch (I got to use "git bisect" for the first time):
> <patch> > commit 55774b512fdf63c0516d441cc5da7c54bbffb7f2 > Author: Nobuhiro Iwamatsu <[EMAIL PROTECTED]> > Date: Fri Mar 7 16:04:25 2008 +0900 > > pci: Add CONFIG_PCI_SKIP_HOST_BRIDGE config option <snip> > The patch changes the behavior of the code _unless_ > CONFIG_PCI_SKIP_HOST_BRIDGE is defined. Defining that switch in the > Korat configuration fixes the problem. The MPC8323ERDB configuration > has also been patched to add the switch, so maybe this is is the cause > of your problem as well. > > I was going to submit the patch for Korat, but then decided I'd first > like to ask Nobuhiro and the group whether it might not be better to > change the occurrences of > > #if defined(CONFIG_PCI_SKIP_HOST_BRIDGE) > > in "drivers/pci/pci.c" to > > #if !defined(CONFIG_PCI_NO_SKIP_HOST_BRIDGE) > > That would allow those boards that need to patch to specify it > explicity, while leaving the default functionality unchanged. > > Comments? Yes, I totally agree. Patches should *not* change the default behavior. We should change it as you suggested. Sorry, I must have missed this. Nobuhiro, could you please send a new patch to fix this problem? Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
