In message <[EMAIL PROTECTED]> you wrote: > > This patch add basic support to the ixp465 cpu. ... > diff --git a/cpu/ixp/start.S b/cpu/ixp/start.S > index 757cfaa..af718b0 100644 > --- a/cpu/ixp/start.S > +++ b/cpu/ixp/start.S > @@ -29,7 +29,8 @@ > > #include <config.h> > #include <version.h> > -#include <asm/arch/ixp425.h> > + > +#include <asm/arch/hardware.h> > > #define MMU_Control_M 0x001 /* Enable MMU */ > #define MMU_Control_A 0x002 /* Enable address alignment faults */ > @@ -158,6 +159,16 @@ reset: > ldr r2, =IXP425_EXP_CS0 --------------------^^^^^^^^^^^^^^^^
Seems there is IXP425 specific stuff here. Please verify that this is correct. If it is correct, then probably the name should be changed. > +#ifdef CONFIG_IXP465 ... > +#ifdef CONFIG_IXP425 ... > +#ifdef CONFIG_IXP465 ... > +#ifdef CONFIG_IXP465 ... > +#else ... > +#ifdef CONFIG_IXP465 ... > +#ifdef CONFIG_IXP465 ... > +#else That's a pretty mess of #ifdef's. Maybe we should split this into separate source files? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] If you hear an onion ring, answer it. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
