On Tue, 2008-05-06 at 20:16 -0700, Grant Erickson wrote: > Changed implementation such that fw_printenv returns failure status when one > or more specified variables do not exist or when incorrect command syntax is > used. > > This aids scripting fw_printenv such that the script can key of the return > status rather than relying on standard error "scraping". > > Tested On: > AMCC Kilauea > > Tests Run: > [EMAIL PROTECTED] fw_printenv > bootdelay=5 > baudrate=115200 > ... > [EMAIL PROTECTED] echo $? > 0 > > [EMAIL PROTECTED] fw_printenv -n hostname > kilauea > [EMAIL PROTECTED] echo $? > 0 > > [EMAIL PROTECTED] fw_printenv -n hostname ipaddr > ## Error: `-n' option requires exactly one argument > [EMAIL PROTECTED] echo $? > 1 > > [EMAIL PROTECTED] fw_printenv hostname ipaddr > hostname=kilauea > ipaddr=192.168.1.12 > [EMAIL PROTECTED] echo $? > 0 > > [EMAIL PROTECTED] fw_printenv foobar > ## Error: "foobar" not defined
This error message should not be there. It is enough to return exit status 1. Then one does not have to redirect stderr in scripts > [EMAIL PROTECTED] echo $? > 1 > > [EMAIL PROTECTED] fw_printenv hostname ipaddr foobar > hostname=kilauea > ipaddr=192.168.1.12 > ## Error: "foobar" not defined Same here. > [EMAIL PROTECTED] echo $? > 1 > Could you also remove the messages printed during fw_setenv(show below)? [EMAIL PROTECTED]:~# fw_setenv kalle sven Unlocking flash... Done Erasing old environment... Done Writing environment to /dev/mtd2... Done Locking ... Done Perhaps hide them behind a -v(verbose) option? ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
