On 5/7/08 12:29 AM, Joakim Tjernlund wrote:
> On Tue, 2008-05-06 at 20:16 -0700, Grant Erickson wrote:
>> [EMAIL PROTECTED] fw_printenv foobar
>> ## Error: "foobar" not defined
>
> This error message should not be there. It is enough to return exit
> status 1. Then one does not have to redirect stderr in scripts
>
>> [EMAIL PROTECTED] fw_printenv hostname ipaddr foobar
>> hostname=kilauea
>> ipaddr=192.168.1.12
>> ## Error: "foobar" not defined
>
> Same here.
>
>> [EMAIL PROTECTED] echo $?
>> 1
>>
>
> Could you also remove the messages printed during fw_setenv(show below)?
> [EMAIL PROTECTED]:~# fw_setenv kalle sven
> Unlocking flash...
> Done
> Erasing old environment...
> Done
> Writing environment to /dev/mtd2...
> Done
> Locking ...
> Done
>
> Perhaps hide them behind a -v(verbose) option?
Joakim,
Agreed that there should be a way to suppress or, alternatively, enable
these verbose status messages. However, these messages were all in the code
already.
So, to the extent that the maintainer (Wolfgang?) is amenable to adding
another option ("-v" or "-q"), I can evaluate working on this change as a
separate patch.
Another change I am also looking into is eliminating the write to flash even
when a variable does not exist:
[EMAIL PROTECTED] fw_printenv foobar
## Error: "foobar" not defined
[EMAIL PROTECTED] echo $?
1
[EMAIL PROTECTED] fw_setenv foobar
Unlocking flash...
Done
Erasing old environment...
Done
Writing environment to /dev/mtd4...
Done
Locking ...
Done
[EMAIL PROTECTED] echo $?
0
Regards,
Grant
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
