In message <[EMAIL PROTECTED]> you wrote: > Replace COBJS-y with appropriate driver config names. > > Signed-off-by: Shinya Kuribayashi <[EMAIL PROTECTED]> > --- > > Changes v2: > > * Kill more CONFIG_CMD_NET and CONFIG_NET_MULTI defines from > - fsl_mcdmafec.c > - mcffec.c > - netarm_eth.c > > * Revised DM9000 part against the net repo.
Hm... Are you absolutely sure your changes, especially the CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not cause any trouble on any systems? Let's for example check the E1000 network driver. with your changes, it will be built (and enabled), if... ... > +COBJS-$(CONFIG_E1000) += e1000.o ... ... if CONFIG_E1000 is set. However, the old code: ... > -#if defined(CONFIG_CMD_NET) \ > - && defined(CONFIG_NET_MULTI) && defined(CONFIG_E1000) > - ...*also* required that CONFIG_CMD_NET *AND* CONFIG_NET_MULTI were set, too. [For the E1000 driver this is easy to verify, as only few boards enable this option, but you are changing this for many drivers, so it affects many boards...] It seems not obvious to me that your change is really harmless, or tested. Could you please comment? [Note that I like your patch and would like to apply it (or ask Ben to do that), but it seems kind of risly to me...] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] If it has syntax, it isn't user friendly. ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
