Wolfgang Denk wrote: > Hm... Are you absolutely sure your changes, especially the > CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not > cause any trouble on any systems?
[...] > It seems not obvious to me that your change is really harmless, or > tested. > > Could you please comment? Carefully reviewed as much as I could, but yes it's not fully tested. I only did some build tests before patch submission. I expect all board config files, which have one of the existing ethernet driver config, already have CONFIG_CMD_NET and CONFIG_NET_MULTI, too. But even if that is the case, there still might be some build breakage. One of possible down sides of this change, upcomming ports or fully new ports might encounter build failures due to missing symbols caused by the lacks of libnet.a, command/cmd_bdinfo.o or something. [ this could be easily fixed (and must be fixed at the end). ] Avoiding unnecessary build failures like this, hence prefer the tight coupling of net|driver|command configs, please revert the patch. Patch seems already applied to upstream contrary to Wolfgang's comment. Shinya ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
