On Jul 8, 2008, at 4:42 PM, Paul Gortmaker wrote: > > I was updating a sbc8560 from u-boot v1.2.0 to git-current, and found > that I'd loose the kernel serial console when the 8250 driver took > over > from udbg0 when using u-boot 1.3.x (booting via tftp'ing the dtb and > the uImage separately) > > I eventually tracked it down to mpc85xx/fdt.c stomping on the contents > of the UART clockrate in the dtb. Since the sbc8560 is sort of > different -- in that it has external UARTs (instead of SOC/CPM), I'm > guessing few other boards see this problem, because bi_busfreq is > really their correct UART clk. > > I fixed it with this simple patch, but I was wondering whether it > would > be better to alternatively just check if the dtb value is zero, and > then only insert a value; otherwise leave it alone...
I think that should be left up to a board to decide, but in general it seems like doing the setting unconditionally is ok, we just didn't handle the case you had and the patch address it. - k ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
