On Wed, Jul 30, 2008 at 12:44 AM, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > "Ben Warren" <[EMAIL PROTECTED]> wrote: >> >> >> extern int macb_eth_initialize(int id, void *regs, unsigned int >> >> >> phy_addr); >> > >> > We're getting more and more of these. Does anyone know an appropriate >> > header to put it in? >> > >> At one point I had a netdev.h file, but removed it because it only >> contained this type of definition. Maybe it's time to resurrect. > > Yeah, perhaps that would be nice. I get the feeling this isn't the only > instance of this kind of thing: > > ~/work/u-boot/upstream$ find -name '*.c' | xargs grep '^extern' | wc -l > 1042 > Yikes. I don't mean to be an ass, but did you know that modern grep has a '-R' (recurse) switch? e.g. $ grep -R --include *.c '^extern' * | wc -l
> All of those instances are potentially dangerous. The > macb_eth_initialize() thing has certainly blown up in my face before... > > Btw, shouldn't board_eth_init() and cpu_eth_init() be declared in some > header file as well? It might catch the wrong function definitions > you've pointed out quite a few times already. > Yeah, the fact that I've corrected several wrong return types in one day makes me think it's time. thanks, Ben ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
