On Thu, Aug 21, 2008 at 11:55:26PM +0000, Tsi-Chung Liew wrote:
> @@ -96,7 +96,7 @@ int board_nand_init(struct nand_chip *nand)
>       nand->ecc.mode = NAND_ECC_SOFT;
>       nand->cmd_ctrl = nand_hwcontrol;
>       nand->read_byte = nand_read_byte;
> -     nand->write_byte = nand_write_byte;
> +     nand->write_buf = nand_write_byte;

nand_write_byte() is not a suitable implementation for nand->write_buf.

> diff --git a/board/freescale/m5373evb/nand.c b/board/freescale/m5373evb/nand.c
> index 404a9c3..bce8679 100644
> --- a/board/freescale/m5373evb/nand.c
> +++ b/board/freescale/m5373evb/nand.c
> @@ -46,16 +46,14 @@ static void nand_hwcontrol(struct mtd_info *mtdinfo, int 
> cmd, unsigned int ctrl)
>  
>       if (ctrl & NAND_CTRL_CHANGE) {
>               ulong IO_ADDR_W = (ulong) this->IO_ADDR_W;
> -             IO_ADDR_W &= ~(SET_ALE | SE_CLE);
> +             IO_ADDR_W &= ~(SET_ALE | SET_CLE);
>  
>               if (ctrl & NAND_CLE)
>                       IO_ADDR_W |= SET_CLE;
>               if (ctrl & NAND_ALE)
>                       IO_ADDR_W |= SET_ALE;
>  
> -             at91_set_gpio_value(AT91_PIN_PD15, !(ctrl & NAND_NCE));
>               this->IO_ADDR_W = (void *)IO_ADDR_W;
> -
>       }

ACK this part.

-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to