Lucas,

-----Original Message-----
From: Lucas Stach [mailto:[email protected]] 
Sent: Friday, January 25, 2013 7:41 AM
To: [email protected]
Cc: Tom Warren; Marek Vasut; Simon Glass; Stephen Warren
Subject: [PATCH v2 0/7] Move Tegra EHCI drive to correct place

This moves out the Tegra EHCI driver from a platform specific directory to the 
standard driver/usb/host dir.

This is a preparation needed to share this driver between Tegra20 and Tegra30. 
No functional change in here, so Tegra30 is still not working.

Patch 6 could be a lot smaller if it were generated with -B, as GIT would 
detect that most of it is moving stuff over, but last time I did this it 
prevented git apply to work. So sorry for the big diff.

I think I incorporated all changes needed to reflect the review feedback I got 
on this last time.

I expect this series to go in through the Tegra tree.

I tried to apply this to u-boot-tegra/next and it needed some massaging to get 
it to apply cleanly. Minor stuff, but you'll need to rebase it on top of 
current u-boot-tegra/next (I just pushed a new version with my 'Move common 
clock code' patch and Allen's fix for the DTS sort patch. Sorry, but the Tegra 
repo is going to be fairly dynamic for the next few weeks.

Also, when I did get it applied and tried to ./MAKEALL -s tegra20 -s tegra30, I 
got the following warning on all T20 builds:

ehci-tegra.c: In function 'ehci_hcd_init':
ehci-tegra.c:565: warning: assignment makes pointer from integer without a cast
ehci-tegra.c:566: warning: assignment makes pointer from integer without a cast

Also, it appears that arch-tegra20/usb.h is still hanging around (in my edited 
patch series, at any rate). Shouldn't the moved arch-tegra/usb.h be used 
exclusively? Removing arch-tegra20/usb.h causes fatal errors in 
nvidia/common/board.c. If it does need to exist, then it needs to live in 
arch-tegra30, also, so it'll be available when T30 gets USB turned on.

Tom


Lucas Stach (7):
  tegra: usb: set USB_PORTS_MAX to correct value
  tegra: usb: make controller init functions more self contained
  tegra: usb: remove unneeded function parameter
  tegra: usb: move controller init into start_port
  tegra: usb: various small cleanups
  tegra: usb: move implementation into right directory
  tegra: usb: move [start|stop]_port into ehci_hcd_[init|stop]

 arch/arm/cpu/armv7/tegra20/Makefile                |   1 -
 arch/arm/cpu/armv7/tegra20/usb.c                   | 567 ---------------------
 .../include/asm/{arch-tegra20 => arch-tegra}/usb.h |  22 -
 arch/arm/include/asm/arch-tegra20/tegra.h          |   1 -
 arch/arm/include/asm/arch-tegra30/tegra.h          |   2 +
 board/nvidia/common/board.c                        |   2 +-
 drivers/usb/host/ehci-tegra.c                      | 546 +++++++++++++++++++-
 7 files changed, 533 insertions(+), 608 deletions(-)  delete mode 100644 
arch/arm/cpu/armv7/tegra20/usb.c  rename arch/arm/include/asm/{arch-tegra20 => 
arch-tegra}/usb.h (89%)

--
1.8.0.2
--
nvpublic


_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to