Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20090323212514.ga30...@ld0162-tx32.am.freescale.net> you wrote: >>> + /* Check for invalid block mark */ >>> + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0xffff)) >>> + return 1; >> Unnecessary parens. > > Where? I find them pretty useful.
Around the second comparison. Why "if (a < b && (c != d))" and not "if (a < b && c != d)", or if the parens are preferred, "if ((a < b) && (c != d))"? Is it because "c" is a function call? > Please keep! OK -- I guess this is another of the unwritten points on which U-boot's style deviates from that which is typical in Linux. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
