-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/04/2013 05:05 PM, York Sun wrote: > On 04/04/2013 01:33 PM, Wolfgang Denk wrote: >> Dear Pali Rohár, >> >> In message <201304041946.55455@pali> you wrote: >>> >>> u-boot "true" and "false" hush commands are copiled >>> incorrectly in uboot v2013.04-rc2 >>> (c8142633e169665b246352918df5b76fd243bb71) >>> >>> when I run help in u-boot it show: >>> >>> # help 0 - do nothing, unsuccessfully 1 - do >>> nothing, successfully ? - alias for 'help' base - >>> print or set address offset ... >>> >>> Instead "0" and "1" there should be "false" and "true" >>> command. >> >> I confirm the problem. >> >> York, your commit 472d546 "Consolidate bool type" is causing this >> issue, so I suggest you send a fix, please. >> >> Please check for other, similar use cases. >> >> > > I found the cause but I don't know the best fix. Please help. > > This is cause by common/cmd_test.c. It has command "true" and > "false". Shall I undef true and false before the U_BOOT_CMD in > this file, or use True and False as the names? If there is a better > way to do that, please enlighten me.
The problem is with how U_BOOT_CMD is constructed. We pass in the command name as the first arg, but don't stringify it until some levels later. I can't think of a better work-around than #define _STDBOOL_H at the top, with a big fat comment. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRXfKZAAoJENk4IS6UOR1Wn2oP/RpQll6j7FanZr5ClwgFwerX 2ESvlkoGmrhlz5lFzk2IPXl8ZGsSVjVFdjkbPZgcXzHcYTGFNi/+wCCALp0GD7D5 G3JVQFeYPEB+3/C+d98jcsex/8wGNPdQXZI6oYhH1yXyXrbhQdVij/ieX/aTYepG iOb9hXwf2P80uNwnnoVN6b9QEfy09hWcgpv0cnfREOykRv0cEq0Ybj7PioGxiXuh RtdVK2o3K0Zw4ruLq7FNUL5vF6AUPOrqDbtlC0Hd3n0shfqEWlAjbQLvBJougLba HHvCCQe/nr6o88vJ+SCGwWIZ/xHTQf/zX064pWGCpMQKKOZEP6/pR97EL9s6Jga1 2Hb795bBeCZYuKFJhcmmIQqJ+5uCqbWBXGMoSlrZim5rWmAteYGCtBXuY2iqVbbY KJ+PO1C9vZJM3FiY0+4ctNrETTyzXyDb9k0umiZUviZBwTJX2ll2pvg/f7/7hdL/ HfAc+FiiyV3NwgL1eT0BduEfT0PyIsswFqKGbK3dTs/6d53E6Dr0S0I4OGHBT2up 1StlfuFw2jEfwNiPHnXJoYyDjjxkDP78Jb35WJB22WeNH73Zj1TtRTYA1Wagvzqs 7yE8iaUI7g2hyBk9XW8xqoHE4ziPUCvXQfunxd7C2Xy7mTyKYKXKwDWIpwj+MKmr DNezPxxDIQSjDryhUfEg =vWhK -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
