On 05/15/2013 06:58:44 PM, Tom Rini wrote:
On Wed, May 15, 2013 at 03:02:19PM +0800, [email protected]
wrote:
> From: Ying Zhang <[email protected]>
>
> Add the symbol CONFIG_SPL_BUILD_MINIMAL for the minimal SPL. It
used to
> eliminate code unused in the minimal SPL but used in the SPL.
[snip]
> diff --git a/common/env_common.c b/common/env_common.c
> index 906b41f..5d82ea0 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -156,7 +156,7 @@ int set_default_vars(int nvars, char * const
vars[])
> H_NOCLEAR | H_INTERACTIVE, nvars, vars);
> }
>
> -#ifndef CONFIG_SPL_BUILD
> +#ifndef CONFIG_SPL_BUILD_MINIMAL
> /*
> * Check if CRC is valid and (if yes) import the environment.
> * Note that "buf" may or may not be aligned.
Hold up, this ignores the whole world of CONFIG_SPL_FRAMEWORK and
probably breaks the ARM targets. You need to instal an ARM toolchain
(either one of the Linaro ones or ELDK 5.x) and make sure that MAKEALL
-a arm is also fine after your SPL changes.
Not to mention that the "minimal init" concept is currently only
well-defined for mpc85xx, so this really doesn't belong in common/.
Minimal 85xx SPLs don't even include libcommon, so why is this change
needed at all?
-SCott
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
