On 06/17/2013 12:01:01 AM, Heiko Schocher wrote:
before writing the received buffer to nand, erase the nand
sectors. If not doing this, nand write fails. See for
more info here:
http://lists.denx.de/pipermail/u-boot/2013-June/156361.html
Signed-off-by: Heiko Schocher <h...@denx.de>
Cc: Scott Wood <scottw...@freescale.com>
Cc: Pantelis Antoniou <pa...@antoniou-consulting.com>
Cc: Lukasz Majewski <l.majew...@samsung.com>
Cc: Kyungmin Park <kyungmin.p...@samsung.com>
Cc: Marek Vasut <ma...@denx.de>
Cc: Tom Rini <tr...@ti.com>
---
- changes for v2:
- use opts.spread as Scott Wood suggested
drivers/dfu/dfu_nand.c | 17 +++++++++++++++--
1 Datei geändert, 15 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c
index 7dc89b2..93db9bd 100644
--- a/drivers/dfu/dfu_nand.c
+++ b/drivers/dfu/dfu_nand.c
@@ -63,12 +63,25 @@ static int nand_block_op(enum dfu_nand_op op,
struct dfu_entity *dfu,
nand = &nand_info[nand_curr_device];
- if (op == DFU_OP_READ)
+ if (op == DFU_OP_READ) {
ret = nand_read_skip_bad(nand, start, &count, &actual,
lim, buf);
- else
+ } else {
+ nand_erase_options_t opts;
+
+ memset(&opts, 0, sizeof(opts));
+ opts.offset = start;
+ opts.length = count;
+ opts.spread = 1;
+ opts.quiet = 1;
+ /* first erase */
+ ret = nand_erase_opts(nand, &opts);
+ if (ret)
+ return ret;
+ /* then write */
ret = nand_write_skip_bad(nand, start, &count, &actual,
lim, buf, 0);
BTW, I notice you are currently using the limit functionality of
nand_read/write_skip_bad... opts.spread currently does not have this
support (as I noted before), which means that if there's an error you'd
erase too much and then refuse to write.
Maybe we need an opts.limit?
adjust_size_for_badblocks, OTOH, is probably the opposite of what you
wanted -- it subtracts from the size in order to get the number of good
blocks within an interval, rather than adding the number of bad blocks
to turn a data size into an interval. It's meant to produce an input
to be used with skipping/spreading operations.
Which makes me think we have a bug in cmd_nand.c -- we should be
setting .spread in erase cases where we call adjust_size_for_badblocks.
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
