Hi Wolfgang, On Sat, Oct 5, 2013 at 1:49 PM, Wolfgang Denk <[email protected]> wrote:
> Dear Simon, > > with commit a8f6ab5 "fs: Add support for saving data to filesystems" > you add the function do_save() to U-Boot. This includes the following > code (line numbers as of current master): > > "fs/fs.c": > > ... > 331 filename = argv[3]; > 332 addr = simple_strtoul(argv[4], NULL, cmdline_base); > 333 bytes = simple_strtoul(argv[5], NULL, cmdline_base); > 334 if (argc >= 7) > 335 pos = simple_strtoul(argv[6], NULL, cmdline_base); > 336 else > 337 pos = 0; > > > Should we not perform at least minimal error checking, i. e. verify > that no garbage arguments have been passed to that function? > Do you mean passing an 'endp' parameter instead of NULL to simple_strtoul() and checking that it processed at least one character? I compared it to do_load() and it seems similar. Regards, Simon
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
