-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/29/2013 10:17 AM, Hardik Patel wrote: > Tom, Dan, > > Thanks for your feedback on patch. > > If I understand correctly, you are suggesting to put static timing > values for RevB3(instead of putting it for auto detection) in > "emif_get_reg_dump" > and "emif_get_dmm_regs_sdp" functions as we do it for other panda > revisions. > > We have already figured out timing values for Elpida RAM on Rev B3. > However, We need a way to differentiate "Rev-B2" and "Rev-B3", as both > boards are very similar. We have checked that "omap_revision()" returns > same value on both B2 and B3. > > We have found one difference between both revisions that we may use. > GPIO171 is '0' for Rev B1/B2, and it comes to '1' for Rev B3. We have > verified this between two boards. > * GPIO2, GPIO3, GPIO171, GPIO48, GPIO182: 0 0 0 1 1 => B1/B2 > * GPIO2, GPIO3, GPIO171, GPIO48, GPIO182: 0 0 1 1 1 => B3 > > Please suggest a correct way to differentiate between B2 and B3 in > "sdram_elpida.c", so that patch gets accepted. > Should we export and use "get_board_revision()" along with > "omap_revision()" in "sdram_elpida.c" to differentiate between B2 and > B3? In current code "get_board_revision()" is not exported to > "sdram_elpida.c".
Note that emif_get_device_details is a weak function, so you can just add one to board/ti/panda/panda.c that will provide the correct data out of sdram_elpida.c, and not have to modify the function in sdram_elpida.c - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSb9pPAAoJENk4IS6UOR1WJe0QAJZwCubK04YYMVPHcSXPw6ND TXg1RR/8IC0UWpStKvj4BBobF/M2bemK4Bw+Rfu/tQLLP7Q92/WK0n02VVOYhWTN kg1FnXDzjGzjvB7KKt+CMftNAYH0PQn1VmbMgQFf4qlteL5oCNT4gZl3YOppYSo5 47g3ckBh51IwwGPPB2hjyFJwWn1IOUtYFEL+HlIXO70fT8Z5hUHcPQPXN/53l3QJ cM6z7hJV43oSYLjaQ7RBc4FQoU2xfNd2EQpmogd58GC1grVfiDxZ2iDaSNdUBRwk RcNZRobRkjPDEbG2eLVq+NeFR6UOsEmjB/ZirWOskWnegAqLl3XRBhlUSAg8cJIF EaBL8M3r/BxH+yn7J2okyTvQ7H2BkUKIqGV1KS5EFCFMAjiFg1Bx3/Ua4NLpDv+N xIjw0X/XojZ2NIrDXgqOKRKr7Sh5NYqfUSQzyE1t5YJ2k91b8QjNd4vnxsz6iwxe 5d3DXE29nyFgUtcyyJNOm5+nYqOBN9MJOWRFROb8GHFzzgERzW1V07D0W+LSc9cy Zx7c9SShVWmrKZJHtNDiMetUV6pqDU3v1BTXkqw0ocF/uwm0Il0uvk/GrNs1+D62 WziWXd5qXok67Ynmrf1gsE8Ol29Axf1Br1H2DPgqfkUr2pI57vX2x8UbQen+4Zie lO5ipCHEw6czTUMz/5o+ =Mfm1 -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot