Hi On Thu, Nov 14, 2013 at 5:19 PM, Tom Rini <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/14/2013 05:06 AM, Hardik wrote: >> From: Hardik Patel <[email protected]> >> >> Signed-off-by: Hardik Patel <[email protected]> >> --- >> arch/arm/cpu/armv7/omap4/sdram_elpida.c | 2 +- >> board/ti/panda/panda.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/cpu/armv7/omap4/sdram_elpida.c >> b/arch/arm/cpu/armv7/omap4/sdram_elpida.c >> index e4c8316..9fbdeea 100644 >> --- a/arch/arm/cpu/armv7/omap4/sdram_elpida.c >> +++ b/arch/arm/cpu/armv7/omap4/sdram_elpida.c >> @@ -123,7 +123,7 @@ static void emif_get_reg_dump_sdp(u32 emif_nr, const >> struct emif_regs **regs) >> *regs = &emif_regs_elpida_200_mhz_2cs; >> else if (omap4_rev == OMAP4430_ES2_3) >> *regs = &emif_regs_elpida_400_mhz_1cs; >> - else if (omap4_rev < OMAP4470_ES1_0) >> + else if (omap4_rev < OMAP4470_ES1_0 && !is_panda_es_rev_b3()) >> *regs = &emif_regs_elpida_400_mhz_2cs; >> else >> *regs = &emif_regs_elpida_400_mhz_1cs; >> diff --git a/board/ti/panda/panda.c b/board/ti/panda/panda.c >> index c104024..5a7f80a 100644 >> --- a/board/ti/panda/panda.c >> +++ b/board/ti/panda/panda.c >> @@ -122,6 +122,30 @@ int get_board_revision(void) >> return board_id; >> } >> >> +/* >> +* Routine: is_panda_es_rev_b3 >> +* Description: Detect if we are running on B3 version of ES panda board, >> +* This can be done by reading the level of GPIO 171 >> +* and checking the processor revisions. >> +* GPIO171: 1 => Panda ES Rev B3 >> +*/ >> +u8 is_panda_es_rev_b3(void) >> +{ >> + int processor_rev = omap_revision(); >> + int ret = 0; >> + >> + if ((processor_rev >= OMAP4460_ES1_0 && >> + processor_rev <= OMAP4460_ES1_1)) { >> + >> + /* Setup the mux for the common board ID pins (gpio 171) */ >> + writew((IEN | M3), (*ctrl)->control_padconf_core_base + >> UNIPRO_TX0); >> + >> + /* if processor_rev is panda ES and GPIO171 is 1, it is rev >> b3 */ >> + ret = gpio_get_value(PANDA_BOARD_ID_2_GPIO); >> + } >> + return ret; >> +} >> + >> /** >> * @brief misc_init_r - Configure Panda board specific configurations >> * such as power configurations, ethernet initialization as phase2 of > > This isn't right. What I was saying is that board/ti/panda/panda.c > needs to provide its own emif_get_reg_dump function, which will (as > designed) override the current one from > arch/arm/cpu/armv7/omap4/sdram_elpida.c >
Any problem to have visibility of emif_regs array of lpddr? Michael > - -- > Tom > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJShPgfAAoJENk4IS6UOR1WROMP/3lqEirFqwVeXUaq2eyphdnD > AQzrzGE3ARc/gb7PqoAKGcvr7HZXQqa/ueRib/QyCRT53gc9S/nJu/wLN/i3NAVJ > 4Y2LOgIkWlPi1k2l1mHvb6SZRVC4ZBFr3MwxoOQCRzMmBCAOwjSzimllT/nA9oSF > 7r2/4tsYpidEoXxK8hn8lKpcfLeAda3MRdQwRjnWXfkJD+rBuAE/w0xCy8I5UmJr > +7J25HFacEbdceexAuzn4wFpSjex5o4yMyD6TFShzsG3GP8aktvWzXi94gx2FZhF > r6526qnjRXH7+RefIVlb95u2+/VpGz9Zu69xga2aszvU+kLHV0s2TTV6SVVmf2aG > Rj4JUxHc6wBYSB3tVNP1NJBiSS3WrmEIlmnQqZXmx51GfJKBHPGaljt5ldGMAUtT > /gtTRw0tw5q/Lv2dHy7BByqxTxk+8iko52X/9zl+vqzKuZS9oOS7/8Wu6q6pXeZc > jm8W/dCRCtO8h1j7BZVJTA+LE05MWKiA6P79lWAR08Eh7U2OwvkCq8WsRBtdxk5z > hqqy09OliHnMliNIRzW5LA8UiBmbw4mXIl27HrX8eNJ0PSXuRFCravm50OLph88L > BQDhKETjVy/dguq/L5lC+FgHwI0U6Hoip20Y8qy/m8YywdutKhw5Zk9jxMZFNCOb > KrOq3OJiJE8d4oSe8VnA > =NxpQ > -----END PGP SIGNATURE----- > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
