On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote: > Add support for the bcm28155_ap reference board. > > Signed-off-by: Darwin Rambo <[email protected]> > Reviewed-by: Steve Rae <[email protected]> > Reviewed-by: Tim Kryger <[email protected]> [snip] > + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
Please use get_ram_size(...);
> +/* Memory testing range */
> +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE
> +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START +
> SZ_1M)
Please see doc/README.memory-test
> +#define CONFIG_SYS_BAUDRATE_TABLE {9600, 19200, 38400, 57600, \
> + 115200, 230400, 460800, 921600}
Unless you really use those higher values in U-Boot, please use the
default table.
> +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
Unneeded now.
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
