-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/30/2014 06:05 PM, Darwin Rambo wrote: > > > On 14-01-29 02:33 PM, Tom Rini wrote: >> On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote: >> >>> Add support for the bcm28155_ap reference board. >>> >>> Signed-off-by: Darwin Rambo <[email protected]> Reviewed-by: >>> Steve Rae <[email protected]> Reviewed-by: Tim Kryger >>> <[email protected]> >> [snip] >>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE; >> >> Please use get_ram_size(...); > We tried using this on our reference board and it hangs accessing > memory regions that are not populated. Our memory controller > doesn't appear to properly support accessing regions that are not > backed by physical sdram. So I think it's best to keep this code as > is and consider this approach for future designs.
Wait, what did you do? get_ram_size(base, max) must work and return CONFIG_SYS_SDRAM_SIZE, or you haven't properly configured your controller (as get_ram_size just pokes parts of the specified range). - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS67BgAAoJENk4IS6UOR1W5/sP/1oi/VC3Vd1Aa9R0Cn833caG ewiuDEWbuXVfa9+yeHIcr/VcyzEF16AxMqUpguaDukI34sdlUHxVlaJKDqLkMp/t fxNRQb8lNK6vhHK3F7xdKiMAFbvAm2fLDLii3mLAZjKGBU6/5kexSaKeklRJbmhz kyLRk3MejoXupNXRhHb48ZK9csgO7JHLNhQCwEIAxzuXhBbnw3Bjt09vBCET0Kfj no4o5TGH9kBOs2/DeO3zSqK3VqbSOgAH1uGYiaiC2cV9vni7Fdq1lshVI/Is+ete 0XkxxfD2pSAerUnQdyiaCJUWxomwLuPxxD/EcNkNMuEBHnOEnYHaNVA9FIdQGJRD GNIiR2UgtktHLedVRsUd19VyGEy3RVPW1urjy59hrU68P1WBxi20nEAxzWi+QuYy KefuYlZfiZ+rHO5P2SOJRPVgrCxcGEfBLztwaeTy2h54asCwctCyx7cwHDJJOkEk 7WtojfwaaaAsL0FGj1XK3hq/MeSjaK1zFOPsnuozZOXLUyEe0iElbqJVO2Ur0UD8 CJugsFM2ywJGsTkk3OvlW7uX1yoMQo5yvV0bNFWhj3XoGX7gpKxiZdFZZkqqc/7U HgTLP4fvLdXLbfdrHamEIQvWHztidsYNlkHdzts7Yzw1e5DszsO16+J/qW5NKcNI 4sfMcXpzoPqiX0WxpEEJ =FNlU -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
