On 17:27 Fri 08 May , Dirk Behme wrote: > Dear Jean-Christophe, > > Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 17:21 Wed 06 May , Dirk Behme wrote: >>> Some OMAP3 boards need control for external power companion >>> chips. Introduce a CONFIG option for this, to avoid Makefile >>> changes for each board. >> >> please also move it to cpu/arm_cortexa8/omap3/ >> >> omap3 and davinci is not a vendor >> so common code will need to go to drivers or cpu/<arch>/<soc> > > No, this wouldn't be correct. We used board/omap3/common/ for this > intentionally. no the current omap3 layout is wrong
it's board/<soc> but it's supposed to be board/<vendor> as davinci which is starting to be clean > > We talk about *board* specific code here, it is totally unrelated to > <arch> or the <soc> we use. This board specific code configures an OMAP3 > (SoC) external companion chip which is on the board (or not). Some boards > which share the basic layout have this companion chip, some not. Please > note that original config options (we remove with this patch) were the > *board* config options (e.g. CONFIG_OMAP3_BEAGLE) to enable the > compilation of power.c, too. as show now the power.c code is shared by a lot's of omap3 boards and as you said it's a power companion for the omap3 so 2 choices move the code to cpu/omap3 as it's omap3 specific or to drivers/ >>> help >>> +Custom configs >>> +============== >>> + >>> +CONFIG_OMAP3_POWER >>> + >>> +Some OMAP3 boards use external power companion chips to be configured. >>> Enable >>> +this CONFIG option in your board specific configuration file if your board >>> +uses such a companion chip. >> could you name it ine the config and the file name > > Sorry, I don't understand what you want here. What should I name where? > Which file name? the name of the companion chip as you can use different one Best Regards, J. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
