+Doug who may have some thoughts here. HI Masahiro,
On 23 June 2014 00:28, Masahiro Yamada <[email protected]> wrote: > Hi Simon, > > On Sun, 22 Jun 2014 22:54:43 -0600 > Simon Glass <[email protected]> wrote: > > > Hi, > > > > On Jun 22, 2014 10:23 PM, "Fabio Estevam" <[email protected]> wrote: > > > > > > On Mon, Jun 23, 2014 at 12:39 AM, Simon Glass <[email protected]> > wrote: > > > > > > > The whitespace problems are not common but they do happen sometimes - > > > > or at least I have seen it at times. Unless perhaps checkpatch has > got > > > > smarter? > > > > > > Couldn't ./scripts/cleanpatch be used to fix the whitespace issues? > > > > Maybe. If you know how to test this please give it a try. > > Note, I do understand all the questions, but the problem is I am not completely sure how this happens. > Does Patman fix the whitespace issues? > > No, it just runs 'git am' which will then report them. > > I'm getting confused. > > To make things clearer, please let me ask you some questions. > > [1] What does "whitespace errors" mean here? > > - Trailing whitespaces ? > - Spaces before TAB indent ? > - Or what else ? > Both of those, plus a blank line at EOF as I understand it. > > [2] What do you expect Patman to do when it finds those errors? > - Just display an error message ? > Yes (it displays an error from 'git am') > or > - Fix the issues automatically ? > No - apart from removing tags and adding notes patman avoids changing patches as a matter of policy. > > [3] Which features were missing from scripts/checkpatch.pl > when you wrote Patman first ? > It's really a belts-and-braces check that nothing will go wrong when the patches are applied. I have had it report errors to me on my own patches, although not recently. I'm not sure if it is still needed though. Regards, Simon
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
