Hi Il 01/set/2014 21:02 "Wolfgang Denk" <w...@denx.de> ha scritto: > > Dear Otavio, > > In message <CAP9ODKonaZ9v76WAdd4k7or_kUWF= attlf+-drqgqyvgkbt...@mail.gmail.com> you wrote: > > > > > But in the next sentence you state that this very file is also used by > > > another board (cgtqmx6qeval) - so apparently it is NOT a board > > > specific file. Actually this makes even more sense to me, as I would > > > expect that the file is more specific to the DDR type than to the > > > board. > > > > > > So why exactly do you think it would be better to move this into a > > > board specific place? > > > > All the calibration has been done by Freescale and for the SABRE SD > > board. This is not guarantee it works in other boards, neither > > expected. Congatec opted to include this file but it is their choice > > and moving to the board file makes it more evident. > > This may be all true, but nevertheless this is NOT board specific > code. And you can already see it being reused by other boards, so the > most natural way to handle it is to factor it out into a common > directory. And actually this is what we had before. > > If we are going to change code, we should have a good reason for such > a change, like fixing bugs, adding features, or cleaning up. What > exactly is that good reason here? Moving code used by more than one > board from a common place to a board-specific one make things worse, > not better. >
Agree with Walfgang Michael > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Until you walk a mile in another man's moccasins, you can't imagine > the smell. > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
