Kim Phillips wrote: > On Mon, 1 Jun 2009 19:14:49 +0900 > "Kim, Heung Jun" <[email protected]> wrote: > >> CC: Dirk Behme <[email protected]> >> Signed-off-by: HeungJun, Kim <[email protected]> >> >> --- >> >> The L2 cache enable/disable function in the cpu/arm_cortexa8/cpu.c moved >> to cpu/arm_cortexa8/omap3/cache.c. >> >> This patches fixes the First issue in the following >> >> http://lists.denx.de/pipermail/u-boot/2009-May/053433.html >> >> The Second issue is fixed by >> >> http://lists.denx.de/pipermail/u-boot/2009-May/053490.html >> > > Hi Riverful, > > 1. the patch title is missing the verb 'move' > 2. your signoff is in the correct location, however the commit message > is not. It belongs above the line with the '---'. > 3. while making backreferences by pointing to messages in the list > archive is cool, they don't stand the test of time - the URL may one > day cease to exist. So it is better to either reference a commitish in > the repository itself, or simply restate/copy the original data.
As long as references to the mailing list archive are in patch comment (below --- as they are here) and don't go into git I think it's fine to use them. Best regards Dirk _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
