On 29/10/2015 11:58, Otavio Salvador wrote: > On Thu, Oct 29, 2015 at 8:53 AM, Stefano Babic <[email protected]> wrote: >> Hi Otavio, >> >> On 29/10/2015 11:32, Otavio Salvador wrote: >>> Congatec has several MX6 boards based on quad, dual, dual-lite and solo. >>> >>> Add SPL support so that all the variants can be supported. >>> >>> Signed-off-by: Otavio Salvador <[email protected]> > ... >>> --- a/board/congatec/cgtqmx6eval/README >>> +++ b/board/congatec/cgtqmx6eval/README > ... >>> +=> sf update 0x12000000 0x400 0x10000 >>> + >>> +=> tftp u-boot.img >> >> Just a nitpick. This assumes that loadaddr is set to 0x12000000, as it >> is in mx6_common.h. If value changes, it is not strictly correct. Maybe >> to avoid confusion, you can write "tftp 0x12000000 SPL" (explicitely >> address it) or you change sf update to use the loadaddr variable as "sf >> update ${loadaddr} 0x400 0x10000" > > Can you replace it with ${loadaddr} when applying or do you want a new > patch revision?
Yes, of course - I'll do it, you do not need to repost it for this. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
