> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Wolfgang Denk > Sent: Monday, August 03, 2009 1:55 PM > To: Aggrwal Poonam-B10812 > Cc: [email protected] > Subject: Re: [U-Boot] [PATCH v2] P2020RDB Platform suppport added > > Dear Poonam, > > In message > <[email protected] > le.net> you wrote: > > > > > So I always recomment to enable the feature - unless you > really have > > > to save a few milliseconds on boot time. > > In that case the API can be really useful. May be I can send the > > modifucation to use this API later. > > Because using it is not quite straight formward on PowerPC. Since I > > need > > Please explain why - we've been using this on PowerPC (where > it has been implemented right in the beginning) for more than > 9 years now, without ever finding it difficult. Could you please point me to some Freescale platform which is using this API so that I can use the implementation as a reference. I searched but could not find. > > > > > +P2020RDB_config: unconfig > > > > + @mkdir -p $(obj)include > > > > + @echo "#define CONFIG_MP" >>$(obj)include/config.h ; > > > > + @$(XECHO) "... setting CONFIG_MP." ; > > > > > > Is this really needed? I'd like to keep such stuff out of the > > > Makefile. > > This would be useful in our case, because the file > > include/configgs/P1_P2_RDB.h is intended to be used for > more than one > > platforms, viz P2020RDB, P1020RDB, P1010RDB , etc. Of them some are > > dual core and some are single core. CONFIG_MP would be required for > > dual core ones. > > We agree about the purpose, but not about the implementation. > Please move this logic intot he board config file. I don't > want to see so many lines of "scripting" in the top level Makefile. > Okay I will move it to configs.h > > > > > > > +#define DATARATE_400MHZ 400000000 #define DATARATE_534MHZ > > > > +534000000 > > > > > > 534 MHz? Not 533.333 = 4 x 133.333 ? > > > You did not comment this one. The settings were suggested by board designer,might be just to take care of the infinite series boundary condition.
> > ... > > > Maybe Freescale should come up with a common set of > setting for all > > > (or at least many) boards, similar to what we have in > > > include/configs/amcc-common.h ? > > A very good suggestion!, This will save us from maintaining the > > redundant stuff at many places. > > May be this change would not be possible immediately, as we > need the > > P2020RDB board support in mainline quickly at the moment. > > Well, it will not got in before the next merge window opens, > which means not before September. Which leaves you with at > least 4 weeks of time for such a cleanup. Okay, but I need to work on other patches also for P2020RDB :( > > Best regards, > > Wolfgang Denk Kind Regards Poonam > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: > [email protected] The greatest threat towards future is indifference. > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
