On Sun, Sep 4, 2016 at 10:32 AM, Jagan Teki <[email protected]> wrote:
> Please do read the thread fully before commenting, I've mentioned the > state of hardware when I relied to Peng. And also this is an RFC patch > I'm looking for comments on function like changes whether the flow of > adding code to existing software is meaningful or not and not intended > to directly applying these onto ML. I have already stated my opinion that you should put your board code into board/engicam. > But I prefer to maintain the same on board/freescale/imx6ul. Becuase, > If the most of the code is common to all boards with specific SOC it's > better to have common code for reusability instead of adding different > board files with duplicate code. For example please see board/sunxi or > board/xilinx/zynq where microzed, zed or zynbo not directly > manufactured from xilinx but they maintained as common. All the ifdefery inside board/sunxi/board.c is exactly what I would like to avoid here. mx6ul is a recent SoC and there is only mx6ul evk and pico mx6ul boards currently supported in U-Boot. I don't think this can scale to support all upcoming boards into a single board/freescale/mx6ul/board.c. Why is mx6ul special in this case compared to the other mx6 variants? Will you be able to support all mx6q boards into board/freescale/mx6q/board.c as well? I am sure this will be unmaintainable. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
