On 15 September 2016 at 12:19, Stephen Warren <swar...@wwwdotorg.org> wrote:
> From: Stephen Warren <swar...@nvidia.com>
> USB ULPI PHY reset signals are typically active low. Consequently, they
> should be marked as GPIO_ACTIVE_LOW in device tree, and indeed they are in
> the Linux kernel DTs, and in DT properties that U-Boot doesn't yet use.
> However, in DT properties that U-Boot does use, the value has been set to
> 0 (== GPIO_ACTIVE_HIGH) to work around a bug in U-Boot.
> This change fixes the DT to correctly represent the HW, and fixes the
> Tegra USB driver to cope with the fact that dm_gpio_set_value() internally
> handles any inversions implied by the DT value GPIO_ACTIVE_LOW.
> Cc: Marcel Ziswiler <marcel.ziswi...@toradex.com>
> Signed-off-by: Stephen Warren <swar...@nvidia.com>
> arch/arm/dts/tegra20-colibri.dts | 3 ++-
> arch/arm/dts/tegra20-harmony.dts | 3 ++-
> drivers/usb/host/ehci-tegra.c | 13 +++++++++++--
> 3 files changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Simon Glass <s...@chromium.org>
U-Boot mailing list