On 07/24/2017 02:05 PM, Marek Vasut wrote: > On 07/24/2017 12:56 PM, Łukasz Majewski wrote: >> On 07/24/2017 09:02 AM, Bin Meng wrote: >>> On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD >>> <[email protected]> wrote: >>>> Hi Marek >>>> >>>> On 07/22/2017 08:36 PM, Marek Vasut wrote: >>>>> On 07/22/2017 08:18 PM, Łukasz Majewski wrote: >>>>>> Hi Marek, >>>>>> >>>>>> When I was "cleaning up" my patchwork todo list I've found following >>>>>> problem (s): >>>>>> >>>>>> A lot of boards are broken with message: >>>>>> >>>>>> LD u-boot >>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_remove': >>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161: >>>>>> >>>>>> undefined reference to `generic_phy_exit' >>>>>> drivers/usb/host/built-in.o: In function `xhci_dwc3_probe': >>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127: >>>>>> >>>>>> undefined reference to `generic_phy_get_by_index' >>>>>> /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134: >>>>>> >>>>>> undefined reference to `generic_phy_init' >>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: >>>>>> >>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail >>>>>> ../../bfd/elf32-arm.c:9512 >>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: >>>>>> >>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail >>>>>> ../../bfd/elf32-arm.c:9512 >>>>>> /opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: >>>>>> >>>>>> BFD (GNU Binutils) 2.28.0.20170307 assertion fail >>>>>> ../../bfd/elf32-arm.c:9512 >>>>>> Makefile:1248: recipe for target 'u-boot' failed >>>>>> >>>>>> The branch is: >>>>>> >>>>>> u-boot-usb/master >>>>>> >>>>>> >>>>>> I've tried to do "bisect" but another error showed up: >>>>>> >>>>>> drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’: >>>>>> drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’ >>>>>> [-Wunused-variable] >>>>>> struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); >>>>>> ^~~~ >>>>>> drivers/usb/host/xhci-dwc3.c: At top level: >>>>>> drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of >>>>>> ‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’ >>>>>> .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata), >>>>>> ^~~~~~ >>>>>> scripts/Makefile.build:280: recipe for target >>>>>> 'drivers/usb/host/xhci-dwc3.o' failed >>>>>> make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1 >>>>>> >>>>>> >>>>>> Patrice and Bin - please fix those errors and make the u-boot-usb tree >>>>>> bisectable again. >>>>> I believe this is already underway since 2 days ago: >>>>> https://www.mail-archive.com/[email protected]/msg256611.html >>>>> >>>> >>>> Regarding the bisection issue detected by Łukasz, it will imposed to >>>> replace my "Extend xhci-dwc3" series already merged into your >>>> u-boot-usb branch. >>>> >>>> How do you want to proceed ? >>>> I can resubmit the full 2 series with all fixes (bisection + compilation >>>> issue) for "usb: Extend ehci and ohci generic driver" and "Extend >>>> xhci-dwc3" >>> >>> I think Marek can drop your previous series on u-boot-usb/master >>> completely then reapply your new series. After all, it's not on >>> u-boot/master yet, so everything can change. >> >> +1 > > I'd prefer incremental changes, so it's easier to review .
Oh, and please, do NOT resubmit patches before getting feedback from me, it really doesn't help. I just deleted both series I had from you. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
