Hi Masahiro, On 16 July 2017 at 21:29, Masahiro Yamada <[email protected]> wrote: > Hi Simon, > > 2017-07-14 23:20 GMT+09:00 Simon Glass <[email protected]>: >> Hi Masahiro, >> >> On 13 July 2017 at 20:38, Masahiro Yamada <[email protected]> >> wrote: >>> Hi Simon, >>> >>> >>> 2017-07-07 12:57 GMT+09:00 Simon Glass <[email protected]>: >>>> Hi Masahiro, >>>> >>>> On 5 July 2017 at 22:49, Simon Glass <[email protected]> wrote: >>>>> On 22 June 2017 at 01:54, Masahiro Yamada <[email protected]> >>>>> wrote: >>>>>> The previous commit renamed ofnode_read_prop() to ofnode_get_propery() >>>>>> and fixed its return type. Likewise, rename dev_read_prop() and fix >>>>>> its return type. >>>>>> >>>>>> Signed-off-by: Masahiro Yamada <[email protected]> >>>>>> --- >>>>>> >>>>>> drivers/core/read.c | 3 ++- >>>>>> drivers/input/key_matrix.c | 4 ++-- >>>>>> include/dm/read.h | 9 +++++---- >>>>>> 3 files changed, 9 insertions(+), 7 deletions(-) >>>>> >>>>> Acked-by: Simon Glass <[email protected]> >>>> >>>> Actually I take that back. I'd like all functions in read.h to start >>>> with dev_read...(). >>>> >>> >>> Do you want me to fix the return type? >> >> Yes void * would be better I suppose. Also what happened with that >> patch with the DEBUG problem? >> > > Why do you need dm_dbg() > instead of generic debug() or pr_debug()?
I don't really understand the question, but debug() / pr_debug() are find. Regards, Simon _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
