Hi Simon,
2017-07-28 13:19 GMT+09:00 Simon Glass <s...@chromium.org>: > Hi Masahiro, > > On 16 July 2017 at 21:29, Masahiro Yamada <yamada.masah...@socionext.com> > wrote: >> Hi Simon, >> >> 2017-07-14 23:20 GMT+09:00 Simon Glass <s...@chromium.org>: >>> Hi Masahiro, >>> >>> On 13 July 2017 at 20:38, Masahiro Yamada <yamada.masah...@socionext.com> >>> wrote: >>>> Hi Simon, >>>> >>>> >>>> 2017-07-07 12:57 GMT+09:00 Simon Glass <s...@chromium.org>: >>>>> Hi Masahiro, >>>>> >>>>> On 5 July 2017 at 22:49, Simon Glass <s...@chromium.org> wrote: >>>>>> On 22 June 2017 at 01:54, Masahiro Yamada >>>>>> <yamada.masah...@socionext.com> wrote: >>>>>>> The previous commit renamed ofnode_read_prop() to ofnode_get_propery() >>>>>>> and fixed its return type. Likewise, rename dev_read_prop() and fix >>>>>>> its return type. >>>>>>> >>>>>>> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >>>>>>> --- >>>>>>> >>>>>>> drivers/core/read.c | 3 ++- >>>>>>> drivers/input/key_matrix.c | 4 ++-- >>>>>>> include/dm/read.h | 9 +++++---- >>>>>>> 3 files changed, 9 insertions(+), 7 deletions(-) >>>>>> >>>>>> Acked-by: Simon Glass <s...@chromium.org> >>>>> >>>>> Actually I take that back. I'd like all functions in read.h to start >>>>> with dev_read...(). >>>>> >>>> >>>> Do you want me to fix the return type? >>> >>> Yes void * would be better I suppose. Also what happened with that >>> patch with the DEBUG problem? >>> >> >> Why do you need dm_dbg() >> instead of generic debug() or pr_debug()? > > I don't really understand the question, but debug() / pr_debug() are find. > In U-Boot, debug() is often used for debugging. My question was, why don't you use it in DM core too? (Then dm_dbg() will be unnecessary, I think.) -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot