On 09/26/2017 10:23 AM, Chee, Tien Fong wrote: > On Isn, 2017-09-25 at 11:15 +0200, Marek Vasut wrote: >> On 09/25/2017 10:40 AM, tien.fong.c...@intel.com wrote: >>> >>> From: Tien Fong Chee <tien.fong.c...@intel.com> >>> >>> Current sdram driver is only applied to gen5 device, hence it is >>> better >>> to rename sdram driver to more specific name which is related to >>> gen5 >>> device. >>> >>> Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com> >>> --- >>> arch/arm/mach-socfpga/include/mach/sdram.h | 434 +------ >>> -------------- >>> .../include/mach/{sdram.h => sdram_gen5.h} | 6 +- >>> drivers/ddr/altera/Makefile | 2 +- >>> drivers/ddr/altera/{sdram.c => sdram_gen5.c} | 0 >>> 4 files changed, 8 insertions(+), 434 deletions(-) >>> copy arch/arm/mach-socfpga/include/mach/{sdram.h => sdram_gen5.h} >>> (99%) >>> rename drivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%) >>> >>> diff --git a/arch/arm/mach-socfpga/include/mach/sdram.h >>> b/arch/arm/mach-socfpga/include/mach/sdram.h >>> index b11228f..4a9754e 100644 >>> --- a/arch/arm/mach-socfpga/include/mach/sdram.h >>> +++ b/arch/arm/mach-socfpga/include/mach/sdram.h >>> @@ -1,5 +1,5 @@ >>> /* >>> - * Copyright Altera Corporation (C) 2014-2015 >>> + * Copyright (C) 2017 Intel Corporation <www.intel.com> >> Retain the old copyright ? >> > Okay. >>> >>> * >>> * SPDX-License-Identifier: GPL-2.0+ >>> */ >>> @@ -8,435 +8,9 @@ >>> >>> #ifndef __ASSEMBLY__ >> What's with this massive deletion here ? >> > Move to sdram_gen5.h . This header should contain common stuff.
Then where did the + part go ? >>> >>> -unsigned long sdram_calculate_size(void); >>> -int sdram_mmr_init_full(unsigned int sdr_phy_reg); >>> -int sdram_calibration_full(void); >>> - >>> -const struct socfpga_sdram_config *socfpga_get_sdram_config(void); >>> - >>> -void socfpga_get_seq_ac_init(const u32 **init, unsigned int >>> *nelem); >>> -void socfpga_get_seq_inst_init(const u32 **init, unsigned int >>> *nelem); >>> -const struct socfpga_sdram_rw_mgr_config >>> *socfpga_get_sdram_rwmgr_config(void); >> [...] -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot