On 28/09/2017 07:34, Peng Fan wrote: > Hi Stefano, > >> -----Original Message----- >> From: Peng Fan >> Sent: Tuesday, September 26, 2017 10:04 AM >> To: 'Stefano Babic' <[email protected]> >> Cc: [email protected]; [email protected]; Fabio Estevam >> <[email protected]> >> Subject: RE: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers >> >> Hi Stefano, >> >> >>> -----Original Message----- >>> From: Stefano Babic [mailto:[email protected]] >>> Sent: Monday, September 25, 2017 10:12 PM >>> To: Peng Fan <[email protected]>; [email protected] >>> Cc: [email protected]; [email protected]; Fabio Estevam >>> <[email protected]> >>> Subject: Re: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers >>> >>> Hi Peng, >>> >>> On 30/08/2017 08:14, Peng Fan wrote: >>>> Enable DM MMC/I2C/PMIC/GPIO/REGULATOR. >>>> >>>> Signed-off-by: Peng Fan <[email protected]> >>>> Cc: Fabio Estevam <[email protected]> >>>> Cc: Stefano Babic <[email protected]> >>>> --- >>>> >>>> V2->V4: none >>>> >> [..........] >> >>>> >>> >>> Enabling DM drivers seems to break sabresd: >>> >>> arm: + mx6sabresd >>> +common/usb_storage.c: In function 'usb_stor_probe_device': >>> +common/usb_storage.c:218:30: error: 'struct usb_device' has no member >>> named 'dev' >>> + data = dev_get_platdata(udev->dev); >>> + ^ >>> +common/usb_storage.c:228:32: error: 'struct usb_device' has no member >>> named 'dev' >>> + ret = blk_create_devicef(udev->dev, "usb_storage_blk", str, >>> + ^ >>> >>> >>> Can you take a look ? >> >> I build mx6sabresd_defconfig, I met the following warning based on imx >> master branch, but did not met the build error. >> CC spl/common/spl/spl_fit.o >> common/spl/spl_fit.c: In function 'spl_load_fit_image': >> common/spl/spl_fit.c:201:7: warning: passing argument 4 of 'gunzip' from >> incompatible pointer type [enabled by default] >> src, &length)) { >> ^ >> In file included from common/spl/spl_fit.c:8:0: >> include/common.h:627:5: note: expected 'long unsigned int *' but argument is >> of type 'size_t *' >> int gunzip(void *, int, unsigned char *, unsigned long *); > > Missed to say that this is not introduced by my patch.
Yes, it is not - it is due to concurrent mergfe of several patches. > Did not meet that error when build mx6sabresd_defconfig? I did not meet that > error based on > master or imx master branch. I got some further errors because I have already merged Fabio's (and someone patch). Fixes look trivial, but I do not want to do this as I cannot test. Could you please take a look and rebase your set on top of current u-boot.imx ? Thanks ! Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
