Hi Dave, On Monday 14 December 2009 22:33:56 David Mitchell wrote: > > > Current de-assert reset is not sufficient for the USB PHY reset > > > on some Canyonlands platforms. The patch adds an assert/de-assert > > > sequence. This addresses a USB detection problem for devices > > > attached prior to power-up. The delay lengths are needed for > > > power to the PHY to stabilize. > > > > > > Signed-off-by: Jeff Mann <[email protected]> > > > Signed-off-by: Dave Mitchell <[email protected]> > > > Acked-by: Tirumala Reddy Marri <[email protected]> > > > --- > > > v1->v2: fixed typo > > > > NAK again. This does not belong in generic board init code. > > I see. Are you asking that all of the USB code be removed? Including the > previous PHY reset implementation done by the original Canyonlands port > (toggling the CPLD reset for the PHY).
Yes, it's probably best to move this USB init code to some place that's called in U-Boot only when USB is really used (a board specific USB init function). And we need to add it to the Linux driver(s) as well. Will you find the time soon to submit such patches? Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: [email protected] _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
