On 01/30/2018 09:07 PM, Sumit Garg wrote: >> -----Original Message----- >> From: York Sun >> Sent: Tuesday, January 30, 2018 2:57 AM >> To: Sumit Garg <[email protected]>; [email protected] >> Cc: Ruchika Gupta <[email protected]>; Prabhakar Kushwaha >> <[email protected]>; Vini Pillai <[email protected]> >> Subject: Re: [PATCH v2] arm64: ls1012ardb: Add distro secure boot support >> >> On 01/15/2018 09:34 AM, Sumit Garg wrote: >>>> From: York Sun >>>> Sent: Monday, January 15, 2018 10:59 PM >>>> >>>> On 01/08/2018 09:59 PM, Sumit Garg wrote: >>>>> From: Vinitha Pillai-B57223 <[email protected]> >>>>> >>>>> Enable validation of boot.scr script prior to its execution >>>>> dependent on "secureboot" flag in environment. Enable fall back >>>>> option to qspi boot in case of secure boot. >>>>> >>>>> Signed-off-by: Sumit Garg <[email protected]> >>>>> Signed-off-by: Vinitha Pillai <[email protected]> >>>>> --- >>>>> >>>>> Changes in v2: >>>>> Rebased to top of master >>>>> >>>>> configs/ls1012ardb_qspi_SECURE_BOOT_defconfig | 14 +++++++------- >>>>> include/configs/ls1012ardb.h | 20 ++++++++++++++++++-- >>>>> 2 files changed, 25 insertions(+), 9 deletions(-) >>>>>
<snip> >>>>> +CONFIG_ENV_IS_IN_SPI_FLASH=y >> >> This is wrong. You shouldn't have ENV for secure boot. Please double check. >> >> York > > Yes you are correct. We should drop this from defconfig. Shall I send next > version or could you drop it while applying the patch? > Applied to fsl-qoriq master, awaiting upstream. Thanks. York _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
