On 04/05/2018 09:12 AM, Dinh Nguyen wrote:
> v
>
> On 04/04/2018 05:56 PM, Marek Vasut wrote:
>> On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
>>> Add a DM compatible reset driver for the SoCFPGA platform.
>>>
>>> Signed-off-by: Dinh Nguyen <dingu...@kernel.org>
>>
>> [...]
>>
>>> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
>>> +{
>>> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
>>> + reset_ctl, reset_ctl->dev, reset_ctl->id);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
>>> +{
>>> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
>>> + reset_ctl->dev, reset_ctl->id);
>>> +
>>> + return 0;
>>> +}
>>
>> Is request/free needed at all ? It looks like a useless debug to me.
>>
>
> I used the code to debug that the i2c driver did hook into the reset
> manager driver. Certainly, it can be removed in the final version. I'll
> send a V3 shortly with this removed.
>
I cannot remove the request function as this is needed in the
reset-uclass driver. Do you want me to remove free? Leaving the code
there seems harmless to me.
Thanks,
Dinh
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
