On Thu, Apr 5, 2018 at 11:28 AM, Marek Vasut <[email protected]> wrote: > On 04/05/2018 04:46 PM, Dinh Nguyen wrote: >> >> >> On 04/05/2018 09:12 AM, Dinh Nguyen wrote: >>> v >>> >>> On 04/04/2018 05:56 PM, Marek Vasut wrote: >>>> On 04/05/2018 12:18 AM, Dinh Nguyen wrote: >>>>> Add a DM compatible reset driver for the SoCFPGA platform. >>>>> >>>>> Signed-off-by: Dinh Nguyen <[email protected]> >>>> >>>> [...] >>>> >>>>> +static int socfpga_reset_request(struct reset_ctl *reset_ctl) >>>>> +{ >>>>> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, >>>>> + reset_ctl, reset_ctl->dev, reset_ctl->id); >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> +static int socfpga_reset_free(struct reset_ctl *reset_ctl) >>>>> +{ >>>>> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl, >>>>> + reset_ctl->dev, reset_ctl->id); >>>>> + >>>>> + return 0; >>>>> +} >>>> >>>> Is request/free needed at all ? It looks like a useless debug to me. >>>> >>> >>> I used the code to debug that the i2c driver did hook into the reset >>> manager driver. Certainly, it can be removed in the final version. I'll >>> send a V3 shortly with this removed. >>> >> >> I cannot remove the request function as this is needed in the >> reset-uclass driver. > > Fix the driver please. > >> Do you want me to remove free? Leaving the code >> there seems harmless to me. > > Do a generic fix and then submit a fix for this driver, so two patches > in total. I'll apply the V2 for now. >
Ok...will do. Dinh _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
