2018-04-23 5:11 GMT+09:00 Simon Glass <[email protected]>: > Hi Masahiro, > > On 17 April 2018 at 20:38, Masahiro Yamada <[email protected]> > wrote: >> device_is_compatible() takes udevice, but there is no such a helper >> that takes ofnode. >> >> Signed-off-by: Masahiro Yamada <[email protected]> >> --- >> >> drivers/core/device.c | 8 +------- >> drivers/core/ofnode.c | 11 +++++++++++ >> include/dm/ofnode.h | 11 +++++++++++ >> 3 files changed, 23 insertions(+), 7 deletions(-) > > Please can you add a call to this to a test? >
No. I do not see any ofnode helper test in test/dm/. You are requesting additional work beyond this patch. It is unfair. This helper is tested indirectly by other tests. Of course, you (and anybody) are free to add per-helper grained tests, but this is not a good reason to block this patch. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
