Hi Masahiro, On 22 April 2018 at 22:50, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-04-23 5:11 GMT+09:00 Simon Glass <s...@chromium.org>: >> Hi Masahiro, >> >> On 17 April 2018 at 20:38, Masahiro Yamada <yamada.masah...@socionext.com > >> wrote: >>> device_is_compatible() takes udevice, but there is no such a helper >>> that takes ofnode. >>> >>> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >>> --- >>> >>> drivers/core/device.c | 8 +------- >>> drivers/core/ofnode.c | 11 +++++++++++ >>> include/dm/ofnode.h | 11 +++++++++++ >>> 3 files changed, 23 insertions(+), 7 deletions(-) >> >> Please can you add a call to this to a test? >> > > No. > > I do not see any ofnode helper test in test/dm/. > > You are requesting additional work beyond this patch. > It is unfair. > > > This helper is tested indirectly by other tests. > > Of course, you (and anybody) are free to add per-helper grained tests, > but this is not a good reason to block this patch.
I understand what you are saying, but you don't need to do any plumbing to make this work. A simple call is enough, perhaps in test-fdt.c? If we get enough tests we can refactor them into a separate ofnode test suite. We should not add code without tests. I plan to go back and add tests for specific calls, but don't want the work to become any harder for me. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
