> -----Original Message----- > From: Michael Trimarchi [mailto:[email protected]] > Sent: 2018年6月21日 4:51 > To: Jagan Teki <[email protected]> > Cc: Stefano Babic <[email protected]>; Peng Fan <[email protected]>; > [email protected]; [email protected] > Subject: [PATCH 2/3] spi: mxc_spi: Fix chipselect on DM_SPI driver uclass > > CS GPIO activation low/high is determinated by the device tree so we don't > need to take in accoung in cs_activate and cs_deactivate
Yes. > > Signed-off-by: Michael Trimarchi <[email protected]> > --- > drivers/spi/mxc_spi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index > fcb214a..0dccc38 > 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -60,7 +60,7 @@ static inline struct mxc_spi_slave > *to_mxc_spi_slave(struct spi_slave *slave) static void > mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) { > if (CONFIG_IS_ENABLED(DM_SPI)) { > - dm_gpio_set_value(&mxcs->ss, mxcs->ss_pol); > + dm_gpio_set_value(&mxcs->ss, 1); > } else { > if (mxcs->gpio > 0) > gpio_set_value(mxcs->gpio, mxcs->ss_pol); @@ -70,7 > +70,7 @@ > static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) static void > mxc_spi_cs_deactivate(struct mxc_spi_slave *mxcs) { > if (CONFIG_IS_ENABLED(DM_SPI)) { > - dm_gpio_set_value(&mxcs->ss, !(mxcs->ss_pol)); > + dm_gpio_set_value(&mxcs->ss, 0); > } else { > if (mxcs->gpio > 0) > gpio_set_value(mxcs->gpio, !(mxcs->ss_pol)); @@ -508,7 > +508,7 > @@ static int mxc_spi_probe(struct udevice *bus) > if (plat->base == FDT_ADDR_T_NONE) > return -ENODEV; > > - ret = dm_gpio_set_value(&plat->ss, !(mxcs->ss_pol)); > + ret = dm_gpio_set_value(&plat->ss, 0); > if (ret) { > dev_err(bus, "Setting cs error\n"); > return ret; > -- Reviewed-by: Peng Fan <[email protected]> > 2.7.4 _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
