Hi all,
On 08/08/2018 11:17, Eugeniu Rosca wrote:
Hello,
FWIW, patch "[7/7] cmd: Add bind/unbind commands to bind a device to a
driver from the command line" contributes with a compiler warning, as
described in https://patchwork.ozlabs.org/patch/933310/#1952127 .
This looks like a false positive to me.
It can be fixed by assigning an initialization value to ret.
Does that require a v4 ?
JJ
Best regards,
Eugeniu.
On Wed, Aug 8, 2018 at 8:36 AM Michal Simek <[email protected]> wrote:
Hi Lukasz,
On 22.6.2018 14:25, Jean-Jacques Hiblot wrote:
This series implements 2 fixes to be able to use USB Ethernet gadget with the
dwc3
driver.
It also adds new commands to bind/unbind a device to/from a driver and
update the 'dm tree' command to make it easier to use those new commands.
The bind/unbind commands can be used to bind the DWC3 USB gadget to the
usb_ether driver from the command line instead of relying on platform code.
Changes in v3:
- update some commit logs
- factorize code based on comments from ML
- remove the devices before unbinding them
- use device_find_global_by_ofnode() to get a device by its node.
Changes in v2:
- Make the bind/unbind command generic, not specific to usb device.
- Update the API to be able to bind/unbind based on DTS node path
- Add a Kconfig option to select the bind/unbind commands
Jean-Jacques Hiblot (7):
usb: gadget: Add bcdDevice for the DWC3 USB Gadget Controller
net: eth-uclass: Fix for DM USB ethernet support
uclass: Add dev_get_uclass_index() to get the uclass/index of a device
dm: print the index of the device when dumping the dm tree
dm: convert device_get_global_by_of_offset() to
device_get_global_by_ofnode()
device: expose the functions used to remove and unbind children of a
device
cmd: Add bind/unbind commands to bind a device to a driver from the
command line
arch/arm/mach-rockchip/rk3188-board-spl.c | 2 +-
arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +-
arch/sandbox/dts/test.dts | 11 ++
cmd/Kconfig | 9 ++
cmd/Makefile | 1 +
cmd/bind.c | 255 ++++++++++++++++++++++++++++++
configs/sandbox_defconfig | 1 +
drivers/core/device-remove.c | 30 ++--
drivers/core/device.c | 19 ++-
drivers/core/dump.c | 16 +-
drivers/core/uclass.c | 21 +++
drivers/usb/gadget/gadget_chips.h | 2 +
include/dm/device-internal.h | 38 +++++
include/dm/device.h | 23 ++-
include/dm/uclass-internal.h | 11 ++
net/eth-uclass.c | 3 +-
test/py/tests/test_bind.py | 178 +++++++++++++++++++++
17 files changed, 584 insertions(+), 38 deletions(-)
create mode 100644 cmd/bind.c
create mode 100644 test/py/tests/test_bind.py
Lukasz: I see your name in patchwork.
Are you going to take this series? Or we are waiting for sandbox testing?
Thanks,
Michal
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
