On Wed, Aug 08, 2018 at 06:44:07PM +0200, Eugeniu Rosca wrote: > On Wed, Aug 8, 2018 at 6:18 PM Jean-Jacques Hiblot <[email protected]> wrote: > > On 08/08/2018 15:08, Eugeniu Rosca wrote: > [snip] > > > I think having a warning-free build is a basic policy everybody is > > > expected to comply with. > > I agree. I meant that it could be fixed at the time of the commit by the > > maintainer. > > I'm not sure how well this plays with https://developercertificate.org/. > At least for my contributions, I would expect that they reach the main > tree unmodified, unless there is some trivial change in commit > metadata (which I expect to be documented). But I'll let others to > comment, who went through such kind of questions before.
In DCO terms, it is my belief that a maintainer can make additional changes, so long as they too add a S-o-B line. I also like it if they do: [me: Did stuff] so it's clear what changed. But I don't think that's a conflict with DCOs. In custodian terms, it's a whole lot quicker if someone can directly apply a series rather than apply, rebase (fixup a patch) and continue. So, if you do another round and fix the problem it'll be one less thing for the custodian to deal with. -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
