On Mon, Dec 3, 2018 at 8:27 AM Kever Yang <kever.y...@rock-chips.com> wrote: > > Hi Tom, > > With this merge, my boards can't work correctly in SPL, the console > output is mess up. > > I have test on rk3229 and rk3399 boards, and finally I identify that > below patch is the root cause: > > 6f57c34473 serial: ns16550: fix debug uart putc called before init
Henri Roosen reported this to me last week. The root cause seems to be that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. He helped me try an additional fix but that didn't work either. So we can either try and fix this if it is only a problem for rockchip boards or revert the patch and I'll think of a different solution to fix this issue (debug uart putc called before init) for the socfpga platform. I still think it would be good to fix this globally: there's nothing keeping us from accidentally adding putc code before the debug uart is initialized and this is something that should be detected, I think. Regards, Simon > > > Thanks, > - Kever > On 11/16/2018 09:45 PM, Tom Rini wrote: > > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: > >> Hi Tom, > >> > >> On 11 October 2018 at 07:10, Tom Rini <tr...@konsulko.com> wrote: > >>> On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > >>> > >>>> Hi Tom, > >>>> > >>>> Here is my attempt at a signed pull request. I've brought in most of the > >>>> outstanding dm patches. Please let me know if it looks OK. Do you have my > >>>> public key? > >>> Is it on the public key servers? > >> Yes, here: > >> > >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index > > So yes, it is working. On your latest PR: > > $ git show --show-signature > > commit 1d6edcbfed2af33c748f2beb399810a0441888da > > merged tag 'pull-14nov18' > > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > > 9008ADE6 > > gpg: Good signature from "Simon Glass <s...@chromium.org>" > > Merge: f6206f8587fc 4c6e27f63c88 > > Author: Tom Rini <tr...@konsulko.com> > > Date: Fri Nov 16 08:37:50 2018 -0500 > > > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > > > Thanks again! > > > > > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot